Pull requests

Code review goal is to share knowledge either by acknowledging changes or suggesting improvements. It’s also discussion, opportunity to ask questions and suggest improvements.

Suggested read - What to look for in a code review

Pull requests (PR) are managed in Azure DevOps. It is possible to create PR via Web interface

Branching

Regular Sprint pull requests are be made against develop branch, but hotfixes and inner source PR's are made against master branch which allows greater flexibility.

Acceptance criteria

• Pull requests must pass build pipeline
• Feature/bugfix must have tests (unit or end to end)
  • Depending on repository there might minimal required test coverage
• All comments must be resolved
  • Comments are marked resolved by comment author

Coding style

It is recommended to follow ACE coding style